Skip to content

Require nikic/php-parser 5 only #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bocharsky-bw merged 1 commit into from
Dec 9, 2025
Merged

Require nikic/php-parser 5 only #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"require": {
"php": "^8.1",
"nikic/php-parser": "^4.0 || ^5.0",
"nikic/php-parser": "^5.0",
Copy link
Member

@bocharsky-bw bocharsky-bw Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain in more detail? I mean, the package allowed v5 before

Copy link
Contributor Author

@nexxome nexxome Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but also v4, and v4 is not doesn't have ParserFactory()->createForVersion()

$parser = (new ParserFactory())->createForVersion(PhpVersion::fromString('8.1'));

So yeah, the change is more likely to disallow v4.

Copy link
Member

@bocharsky-bw bocharsky-bw Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I see we use that createForVersion() in the code, thanks for more details

"symfony/finder": "^5.4 || ^6.4 || ^7.0",
"twig/twig": "^2.0 || ^3.0",
"doctrine/annotations": "^1.7 || ^2.0"
Expand Down
Loading