Improve regex to also match Type[][]

[IanDelMar]

PHPStan does not support the bracketed generic array syntax (string[]). When transforming WordPress’ @type array annotations, the visitor therefore uses a regular expression to replace Type[] patterns with array.

At present, the regex matches only a single level (Type[]) and misses nested forms (Type[][]), which also occur in the WordPress codebase. Missing these nested arrays results in invalid types like @phpstan-param array[]<int|string, array{...

This PR generalises the pattern to support multiple levels of nesting. Because the visitor derives array nesting from indentation, its behaviour is unchanged apart from correctly replacing these Type[][]… cases.

[szepeviktor]

Could we stop mixing array[] and array<>, and use only array<> and array{}?

[szepeviktor]

array[] does not seem to be listed on https://phpstan.org/writing-php-code/phpdoc-types

[IanDelMar]

These are coming from WordPress?! We are not using array[], we have to deal with array[] to build the array shapes.

[szepeviktor]

At the end of the day wp_print_font_faces should have a 2-level array as a parameter.
array<int|string, array{ font-family: string, ... }>
Is it true?

[IanDelMar]

$fonts is supposed to look like

[
	[
		[
			'font-family' => 'Font Family',
			'src' => ['src.woff2'],
			'font-style' => 'normal',
			'font-weight' => '400',
			// ...
		],
		[
			'font-family' => 'Font Family',
			'src' => ['src-700.woff2'],
			'font-style' => 'normal',
			'font-weight' => '700',
			// ...
		],
	],
    [
		[
			'font-family' => 'Other Font Family',
			'src' => ['other-src.woff2'],
			'font-style' => 'normal',
			'font-weight' => '400',
			// ...
		],
		[
			'font-family' => 'Other Font Family',
			'src' => ['other-src-700.woff2'],
			'font-style' => 'normal',
			'font-weight' => '700',
			// ...
		],
	],
];

[szepeviktor]

I see!
So

1. fonts
2. families
3. variations

Is it okay?
array<int|string, array<array{ font-family: string, ... }>>

[IanDelMar]

The formatting in WordPressArg is incorrect. It is formatted using WordPressArg::formatArrayWithoutShape. I won’t be able to look into it any further today.