Skip to content

Enhance property meta with container meta#49

Merged
veewee merged 1 commit intophp-soap:mainfrom
veewee:enhance-proprty-settings-with-container-info
Sep 9, 2025
Merged

Enhance property meta with container meta#49
veewee merged 1 commit intophp-soap:mainfrom
veewee:enhance-proprty-settings-with-container-info

Conversation

@veewee
Copy link
Member

@veewee veewee commented Sep 7, 2025

Q A
Type improvement
BC Break no
Fixed issues phpro/soap-client#586

Summary

Fixes phpro/soap-client#586

❗ Awaiting goetas-webservices/xsd-reader#91 to be merged. This will make the unit test pass.

Currently, the metadata parser does not take into account the minOccurs on group-ref level:

            <xs:complexType name="storeCardResult">
                <xs:sequence>
                    <xs:group minOccurs="0" ref="securityDetailsGroup"/>
                </xs:sequence>
            </xs:complexType>
            <xs:group name="securityDetailsGroup">
                <xs:sequence>
                    <xs:element name="securityDetails" type="securityDetails"/>
                </xs:sequence>
            </xs:group>
            <xs:complexType name="securityDetails">
                <xs:sequence>
                    <xs:element minOccurs="0" name="threeDSecure" type="threeDSecure"/>
                    <xs:element minOccurs="0" name="resultAVVCVV" type="xs:string"/>
                </xs:sequence>
            </xs:complexType>

TODO

@veewee veewee marked this pull request as draft September 7, 2025 08:32
@veewee veewee force-pushed the enhance-proprty-settings-with-container-info branch 4 times, most recently from 22875bc to 4556560 Compare September 8, 2025 18:29
@veewee veewee force-pushed the enhance-proprty-settings-with-container-info branch 3 times, most recently from e33b56b to fa72323 Compare September 9, 2025 10:14
@veewee veewee marked this pull request as ready for review September 9, 2025 10:15
@veewee veewee force-pushed the enhance-proprty-settings-with-container-info branch from fa72323 to 04fb2f4 Compare September 9, 2025 17:27
@veewee veewee merged commit 409bb6a into php-soap:main Sep 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullable group isn't reflected in generated types.

1 participant