Fix setting metadata back to null bugs#24
Merged
veewee merged 1 commit intophp-soap:mainfrom Nov 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes bugs related to setting metadata properties back to null by replacing optional() with nullable() type coercion. The issue was that optional() would not properly handle explicit null values, preventing metadata from being cleared once set.
Key Changes:
- Updated type coercion from
optional()tonullable()for metadata setter methods - Added test coverage verifying that metadata properties can be set back to null
- Added import for
nullabletype function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Metadata/Model/TypeMeta.php | Changed type coercion from optional() to nullable() in withEnums, withExtends, withRestriction, withUnions, and withArrayType methods, and added nullable import |
| tests/Unit/Metadata/Collection/TypeMetaTest.php | Added test assertions to verify metadata properties can be emptied by passing null and return a new instance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary