Skip to content

#730 updatemetadesc#751

Open
AnilKumar3494 wants to merge 9 commits into
developfrom
#730_updatemetadesc
Open

#730 updatemetadesc#751
AnilKumar3494 wants to merge 9 commits into
developfrom
#730_updatemetadesc

Conversation

@AnilKumar3494
Copy link
Copy Markdown
Member

@AnilKumar3494 AnilKumar3494 commented May 10, 2026

Pull Request

Updating a few things to improve SEO

Change Summary

Updated meta tags and the index.html to improve SEO

RESULTS:

Pages now have dedicated routes
--- / (default),
/about,
/join and
/contact
And each page gets dedicated meta data!

for home page
image

for /about page
image

for /join page
image

for /contact page:
image

Each page and resource gets dedicated page title as well.
Example below:
image

@AnilKumar3494 AnilKumar3494 force-pushed the #730_updatemetadesc branch from e87db35 to 55076cc Compare May 10, 2026 00:28
@AnilKumar3494
Copy link
Copy Markdown
Member Author

AnilKumar3494 commented May 12, 2026

This update should create nice sharable cards for different platforms ... this will work once these changes are live in prod.

Another way would be to host the 'tessellation' first and use that URL in all the necessary meta tags content attributes:

<meta
    name="twitter:image"
    content="https://phlask.me/assets/phlask-tessellation.png"
  />

Results:
image

@gcardonag
Copy link
Copy Markdown
Contributor

Code review

Found 3 issues:

  1. Vite public-directory asset imported as ES module instead of referenced by URLSelectedResourceDetails.tsx imports the tessellation image via a relative path into public/, which is incorrect. Vite does not bundle files from public/ through the module system; they should be referenced as URL strings (e.g., '/assets/images/phlask-tessellation.png'), not imported.

import sampleImg from '../../../public/assets/images/phlask-tessellation.png';

  1. og:image and twitter:image URLs are missing the images/ subdirectory and will 404 — The tessellation was moved to public/assets/images/phlask-tessellation.png, but both meta tags in index.html point to https://phlask.me/assets/phlask-tessellation.png (without images/). Social media scrapers will receive a 404 for the preview image.

phlask-map/index.html

Lines 32 to 35 in 4ac8b90

<meta
property="og:image"
content="https://phlask.me/assets/phlask-tessellation.png"
/>

phlask-map/index.html

Lines 46 to 49 in 4ac8b90

<meta
name="twitter:image"
content="https://phlask.me/assets/phlask-tessellation.png"
/>

  1. Default ogImage in SEO.tsx is the favicon, not the tessellation image — All pages using <SEO> without an explicit ogImage override (About, Contact, JoinTheTeam) will render the small favicon as their social share card image. The default should match index.html's og:image: https://phlask.me/assets/images/phlask-tessellation.png.

description,
ogType = 'website',
ogImage = 'https://phlask.me/assets/favicon.png',
canonicalUrl
}: SEOProps) => {

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@gcardonag
Copy link
Copy Markdown
Contributor

Don't mind the Claude review too much, just trying the code review plugin in Claude Code out to see how well it works for us :)

@AnilKumar3494
Copy link
Copy Markdown
Member Author

Don't mind the Claude review too much, just trying the code review plugin in Claude Code out to see how well it works for us :)

-- that's accurate!

@AnilKumar3494 AnilKumar3494 requested a review from gcardonag May 20, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants