Add comprehensive test coverage for bookmarks, crypto, and signaling#37
Merged
pheuberger merged 1 commit intomainfrom Feb 6, 2026
Merged
Add comprehensive test coverage for bookmarks, crypto, and signaling#37pheuberger merged 1 commit intomainfrom
pheuberger merged 1 commit intomainfrom
Conversation
…ions - bookmarks.test.js: inbox validation (title optional for inbox items), favicon/preview field passthrough, tag edge cases (non-string values, non-array input), URL normalization edge cases (encoded chars, IDN) - signaling.test.js: SignalingClient message routing, subscription management, publish queueing, _send state guards, close cleanup, subscribe/unsubscribe/handleMessage integration, getPairingRoomName and getSignalingUrl utilities - crypto-conversions.test.js: base64ToUint8Array (previously untested), round-trip integrity for all buffer conversion functions including cross-function pipelines (string->buffer->base64->Uint8Array), binary data with all 256 byte values, crypto-sized buffers (32B key, 12B IV) https://claude.ai/code/session_014P4FqiX28FYRq7h2V4Dves
✅ Deploy Preview for hypermarkk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds extensive test coverage for three critical service modules: bookmark validation, cryptographic conversions, and WebSocket signaling. The new tests ensure data integrity across encryption pipelines, proper message routing, and robust bookmark handling.
Key Changes
Bookmarks Service Tests (
bookmarks.test.js)Crypto Conversion Utilities Tests (
crypto-conversions.test.js) - NEW FILESignaling Service Tests (
signaling.test.js) - NEW FILEgetPairingRoomNameandgetSignalingUrlhelpersNotable Implementation Details
https://claude.ai/code/session_014P4FqiX28FYRq7h2V4Dves