Fix https://github.com/pharo-project/pharo/issues/19730#1468
Open
guillep wants to merge 1 commit into
Open
Conversation
Contributor
guillep
commented
May 29, 2026
guillep
commented
- do not set a caller class if no methods are set
- cleanup methods with side effects and duplicated code
- cleanup redefined open method, move popup to browse methods, refactor to minimize duplications
- do not set a caller class if no methods are set - cleanup methods with side effects and duplicated code - cleanup redefined open method, move popup to browse methods, refactor to minimize duplications
jecisc
approved these changes
May 29, 2026
Member
|
Some tests are in failure because now the opening does not return the window |
jecisc
added
the
need more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.