Create a call back for the CLI debugger#1442
Open
NathanMalenge wants to merge 4 commits into
Open
Conversation
jecisc
reviewed
May 13, 2026
…tPresenter and StPharoApplication instead) + add comments
guillep
approved these changes
May 13, 2026
Contributor
guillep
left a comment
guillep
left a comment
There was a problem hiding this comment.
Nice! would you mind adding a PR description? It should at least say
- that this depends on the other PR you did in Pharo
- what it is supposed to do and why
Comment on lines
+11
to
+16
| { #category : 'as yet unclassified' } | ||
| TStDebuggerExtensionTestClass class >> acceptsPredicate: aStDebuggerContextPredicate [ | ||
|
|
||
| ^ true | ||
| ] | ||
|
|
Contributor
There was a problem hiding this comment.
This is strange, did you touch this?
Author
There was a problem hiding this comment.
i did not, or not in purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR depending on pharo-project/pharo#19619
While working on a CLI debugger, I had to refactor debugger-Model beacause it used UIManager directly.
So the goal of this PR is to avoid this dependency, using callBacks. We have to have a callBack class in newTools because it's what calls debugger-Model.
We use StApplication and spec to open a dialog instead of UIManager