Skip to content

Conversation

@UncleGrumpy
Copy link

@UncleGrumpy UncleGrumpy commented Dec 9, 2025

I think you will need to rebase for this to merge cleanly, but these changes will help us get atomvm#59 closer to the finish line. We still need to pull in a copy of AtomVM and atomvmlib from main to assemble the escript, we should probably put them in proper install locations.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@UncleGrumpy UncleGrumpy force-pushed the escritpize branch 3 times, most recently from 733718c to f8e0690 Compare December 9, 2025 05:17
This makes a few small adjustments to the escriptize provider as well as the tests, most of these
are necessary changes. A few additional changes have heen made, such as adding the users
$HOME/.local, to the default AtomVV install search paths, and supporting matching on the AtomVM elf
executable, as well as the shell launcher script.

Signed-off-by: Winford <winford@object.stream>
@UncleGrumpy
Copy link
Author

UncleGrumpy commented Dec 9, 2025

I got the workflow updated to build and install the AtomVM runtime allowing the successful completion of the test.

Link to the latest run:
https://github.com/UncleGrumpy/atomvm_rebar3_plugin/actions/runs/20052898511

@pguyot pguyot changed the base branch from w44/escriptize to master December 9, 2025 06:50
@pguyot pguyot changed the base branch from master to w44/escriptize December 9, 2025 06:50
@pguyot pguyot merged commit 468ee62 into pguyot:w44/escriptize Dec 9, 2025
1 check passed
pguyot pushed a commit that referenced this pull request Dec 9, 2025
This makes a few small adjustments to the escriptize provider as well as the tests, most of these
are necessary changes. A few additional changes have heen made, such as adding the users
$HOME/.local, to the default AtomVV install search paths, and supporting matching on the AtomVM elf
executable, as well as the shell launcher script.

Signed-off-by: Winford <winford@object.stream>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants