feat: add application_name_add_host setting#974
Open
Nihal-Pandey-2302 wants to merge 1 commit into
Open
Conversation
Appends the client host address and port to application_name when connecting to the backend, matching PgBouncer behavior. Only applied at connection start, not on subsequent SET commands. Disabled by default. [general] application_name_add_host = true
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
What
Adds
application_name_add_hostsetting to[general]config, matching PgBouncer's behavior.When enabled, PgDog appends the client's IP address and port to the
application_nameparameter when connecting to the backend. This makesit easy to trace which client is behind which backend connection in
pg_stat_activity.Example:
myappbecomesmyapp (192.168.1.5:54321)Behavior
false)SET application_namecommandsConfig
Changes
pgdog-config/src/general.rs-> addedapplication_name_add_host: boolfield toGeneralstructsrc/frontend/client/query_engine/connect.rs-> appends client addr toapplication_namebeforelink_clientis called