Centralize Spock shared memory initialization #318
+362
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor shared memory hook registration into a single spock_shmem.c module. This ensures only one shmem_request_hook and shmem_startup_hook are registered, and AddinShmemInitLock is acquired exactly once. - Add new spock_shmem.c/h for centralized initialization - Remove hook registration from spock_worker.c and spock_output_plugin.c - Add spock_worker_reset_shmem_pointers() for crash recovery - Replace separate init calls with single spock_shmem_init()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor shared memory hook registration into a single spock_shmem.c module. This ensures only one shmem_request_hook and shmem_startup_hook are registered, and AddinShmemInitLock is acquired exactly once.