Skip to content

v2.6.1 Fixes #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredhendrickson13 merged 1 commit into from
Sep 13, 2025
Merged

v2.6.1 Fixes #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Fields/SpecialNetworkField.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,14 @@ class SpecialNetworkField extends InterfaceField {
return $representation_value;
}

# If the value is a NetworkInterface, obtain its representation value if it's not the ID
$if_query = NetworkInterface::query(id: $internal_value);
if ($this->represented_as !== 'id' and NetworkInterface::query(id: $internal_value)->exists()) {
return $if_query->first()->{$this->represented_as}->value;
# When loading the regular internal value (from InterfaceField), if the value is different from the
# internal value, it means it was an interface that got converted from its internal ID. So return it.
$representation_value = parent::_from_internal($internal_value);
if ($representation_value !== $internal_value) {
return $representation_value;
}

# Otherwise, just return the internal value as it is
# Otherwise, just return the internal value as it is (interface ID, alias, IP, subnet, keyword, etc.)
return $internal_value;
}
}