v2.5.2 Fixes #718
Merged
v2.5.2 Fixes #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#716 This commit fixes a bug where pfSense's get_load_average() function returns a load average string that changes based on the system's language setting. Previously, the numbers in the load average string might be separated by just a space, or by a comma and a space. This inconsistency caused an error when the API tried to convert that string into a usable array of values. Now, we're ensuring the load average string is always delimited by a single space, no matter what language pfSense is using. This prevents the logic error and ensures the API can correctly convert the load average to its intended array representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
cpu_load_averagefield from being correctly parsed into an array Uncaught RESTAPI\Responses\ServerError: Cannot parse FloatFieldcpu_load_avg#716