Add uninstall method to clean up plugin options #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds proper cleanup functionality for the Webmention plugin by implementing an uninstall.php file that removes all plugin options when the plugin is deleted, following WordPress plugin development best practices. This ensures users' databases are left clean after uninstalling the plugin while intentionally preserving post and comment meta for data retention.
Key Changes:
- Implements
uninstall.phpwith security guard and cleanup logic for 16 plugin options - Updates changelog to document the new uninstall functionality
- Preserves webmention data in post/comment meta for future reinstallation scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uninstall.php | New file implementing plugin cleanup with WP_UNINSTALL_PLUGIN security check and deletion of all 16 webmention options |
| readme.md | Adds changelog entry documenting the new uninstall method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
force-pushed
the
fix/519-uninstall-method
branch
from
cae8be6 to
7f4f7ea
Compare
Creates uninstall.php to clean up when the plugin is uninstalled: Options removed: - All settings from the settings page - Database version tracking option - Migration lock option Files removed: - Cached avatar files in wp-content/uploads/webmention/avatars/ Note: Post meta and comment meta are intentionally preserved to allow users to reinstall the plugin without losing their webmention data. Fixes #519
pfefferle
force-pushed
the
fix/519-uninstall-method
branch
from
7f4f7ea to
e92c9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
uninstall.phpto properly clean up plugin options when the plugin is deleted, following WordPress plugin development standards.Fixes #519
Options removed on uninstall
webmention_disable_selfpings_same_urlwebmention_disable_selfpings_same_domainwebmention_disable_media_mentionswebmention_support_post_typeswebmention_show_comment_formwebmention_comment_form_textwebmention_home_mentionswebmention_approve_domainswebmention_avatarswebmention_avatar_store_enablewebmention_separate_commentwebmention_show_facepilewebmention_facepile_fold_limitwebmention_send_media_mentions(legacy)webmention_db_versionwebmention_migration_lockNote
Post meta and comment meta are intentionally not deleted to preserve webmention data in case users reinstall the plugin later.
Test Plan
webmention_*options are removed fromwp_optionstable