Fix ext/phar and improve PHP/AddCommand module#56
Merged
Conversation
petk
force-pushed
the
patch-add-command
branch
15 times, most recently
from
bd799e9 to
bbbe065
Compare
This now enables building ext/phar as standalone: cd ext/phar cmake -B cmake-build cmake --build cmake-build ctest --test-dir cmake-build -j --verbose cmake --install cmake-build -j 12 A basic CMake test has been added to ext/phar to ensure that generated phar command-line tool works. All the missing result variables so far related to the found PHP on the host system have been added to config files and FindPHP module (used by Autotools installation). The pkg-config module has been adjusted to not required the TARGET argument anymore. This is done to resolve edge cases when PHP::sapi::cli is disabled. PHP's php.pc file wouldn't even need libraries listed, as it represents a header-only package for building PHP extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now enables building ext/phar as self-contained:
A basic CMake test has been added to ext/phar to ensure that generated phar command-line tool works.
All the missing result variables so far related to the found PHP on the host system have been added to config files and FindPHP module (used by Autotools installation).
The pkg-config module has been adjusted to not required the
TARGETargument anymore. This is done to resolve edge cases whenPHP::sapi::cliis disabled. PHP's php.pc file wouldn't even need libraries listed, as it represents a header-only package for building PHP extensions.