fix: support running Pest when symlinked#1611
Closed
sunchayn wants to merge 1 commit intopestphp:4.xfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
When Pest is installed as a symlinked dependency (e.g., using a Composer path repository), PHP's
__DIR__constant resolves to the physical path of the Pest package (e.g., /Volumes/Dev/pest/bin).This leads to two problems:
tests/Pest.phpfile will not be called. Since the wrong autoloader will load the wrongTestSuiteinstance, the rootpath will be Pest's rootpath instead of the repo's rootpath.