Fix viewport scroll regression in datagrid #3098
Merged
+52
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-viewport-sorting
branch
from
90d9cf1 to
2af1bca
Compare
texodus
commented
Dec 18, 2025
| (x) => x !== "__ROW_PATH__" && x !== "__ID__", | ||
| ); | ||
|
|
||
| const old_length = this._column_paths.length; |
Member
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #3047, which causes broken datagrid behavior after a sort in a certain condition, and adds a test.
Most
Viewchanges in perspective will reset scroll position, but this behavior feels "wrong" when e.g. a sort is applied by clicking on a column header. In #3047 we made such metadata-modifying operations capable of incrementally updating the column defs, but we neglected to account for the possibility that the first such update may not occur when the scroll position is (0. 0) (e.g. after a sort is applied).