-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Build arm64/aarch64 Linux wheels #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7582196
Add DCO check to prepush
tomjakubowski ed29410
Start on building aarch64 linux wheels
tomjakubowski b7a87b7
Add arm64 builds to CI
Oblynx 434b81b
Review comments
Oblynx 7e0734f
Fix protoc().parent() call
tomjakubowski cbfe4ec
Add disk free space reports to Python build
tomjakubowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. husky was warning loudly that this is deprecated and will soon cause errors. The contents of that file now do nothing but echo that warning, so I think it is safe to heed it and remove this. |
||
|
|
||
| pnpm run prepush | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ | ||
| // ┃ ██████ ██████ ██████ █ █ █ █ █ █▄ ▀███ █ ┃ | ||
| // ┃ ▄▄▄▄▄█ █▄▄▄▄▄ ▄▄▄▄▄█ ▀▀▀▀▀█▀▀▀▀▀ █ ▀▀▀▀▀█ ████████▌▐███ ███▄ ▀█ █ ▀▀▀▀▀ ┃ | ||
| // ┃ █▀▀▀▀▀ █▀▀▀▀▀ █▀██▀▀ ▄▄▄▄▄ █ ▄▄▄▄▄█ ▄▄▄▄▄█ ████████▌▐███ █████▄ █ ▄▄▄▄▄ ┃ | ||
| // ┃ █ ██████ █ ▀█▄ █ ██████ █ ███▌▐███ ███████▄ █ ┃ | ||
| // ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫ | ||
| // ┃ Copyright (c) 2017, the Perspective Authors. ┃ | ||
| // ┃ ╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌ ┃ | ||
| // ┃ This file is part of the Perspective library, distributed under the terms ┃ | ||
| // ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃ | ||
| // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | ||
|
|
||
| import "zx/globals"; | ||
|
|
||
| function lint_git(sha) { | ||
| if (!sha || typeof sha !== "string") { | ||
| throw new Error(`invalid sha: ${sha}`); | ||
| } | ||
| const result = $.sync`git log -1 ${sha} | grep -F "Signed-off-by: "`; | ||
| if (result.exitCode !== 0) { | ||
| console.error( | ||
| "`git log -1 " + | ||
| sha + | ||
| "` is missing a Signed-off-by: and DCO check will surely fail.", | ||
| ); | ||
| console.error("To sign off, run:\ngit commit --amend --edit --sign"); | ||
| process.exit(1); | ||
| } | ||
| } | ||
|
|
||
| async function readPrePushInput() { | ||
| // Git supplies information about the push to the hook on stdin. | ||
| // https://git-scm.com/docs/githooks#_pre_push | ||
| const chunks = []; | ||
|
|
||
| if (process.stdin.isTTY) { | ||
| // Makes developing the pre-push script more convenient. In particular | ||
| // when you run `pnpm run prepush` from a shell terminal you don't have | ||
| // to send EOF on stdin. | ||
| return []; | ||
| } | ||
| for await (const chunk of process.stdin) { | ||
| chunks.push(chunk); | ||
| } | ||
|
|
||
| const input = Buffer.concat(chunks).toString(); | ||
| const lines = input.split("\n").filter((l) => l.length > 0); | ||
| return lines.map((line) => { | ||
| const parts = line.trim().split(" "); | ||
|
|
||
| return { | ||
| local_ref: parts[0], | ||
| local_object_name: parts[1], | ||
| remote_ref: parts[2], | ||
| remote_object_name: parts[3], | ||
| }; | ||
| }); | ||
| } | ||
|
|
||
| if (import.meta.main) { | ||
| // Does not actually run all pre-push hook checks (it does not run the repo | ||
| // lint script). These are lints which run only in pre-push. The | ||
| // `prepush` script defined in package.json is responsible for running the | ||
| // repo lint script. | ||
| const pushes = await readPrePushInput(); | ||
| for (const push of pushes) { | ||
| const { local_object_name } = push; | ||
| lint_git(local_object_name); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the thought to include these, but I may prune them in the future for brevity!