Skip to content

Conversation

@onesimus-wiafe
Copy link
Contributor

@onesimus-wiafe onesimus-wiafe commented Oct 29, 2024

This pull request fixes one of the Firefox issues in #2693, specifically issue #1983
I used string interpolation for the style on the rect element (for x and y) to introduce layout consistency by adding px to the d.x0 and d.y0 values. I realized that without this, Firefox ignored some of the values, hence the issue.

Pull Request Checklist

  • Description which clearly states what problems the PR solves.
  • Description contains a link to the Github Issue, and any relevent
    Discussions, this PR applies to.
  • Include new tests that fail without this PR but passes with it.
  • Include any relevant Documentation changes related to this change.
  • Verify all commits have been signed in accordance with the DCO policy.
  • Reviewed PR commit history to remove unnecessary changes.
  • Make sure your PR passes build, test and lint steps completely.

Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Perspective does not currently support FireFox (See #2818) and its generally our policy not to merge fixes for unsupported platforms because they are difficult for correctness. However in this case, this fix is correct and trivial.

@texodus texodus merged commit e2c6502 into perspective-dev:master Dec 2, 2024
13 checks passed
@texodus texodus added the bug Concrete, reproducible bugs label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Development

Successfully merging this pull request may close these issues.

3 participants