[IGNORE] VictoriaLogs: Fix linter issues in VictoriaLogs plugin #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
Although stream processing is probably a fine use of while(true), the linter complains. The `ReadableStreamDefaultReader` interface's `read()` method resolves the Promise with an object that contains a `done` property. Therefore this commit adapts the implementation to use that property instead. See more: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamDefaultReader/read#return_value Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The VictoriaLogs plugin currently accounts for 87 out of the 96 linter issues in the plugins repository. This PR is a maintenance PR for those linter issues. Most of the linter issues were auto-fixable with eslint, a few were unused imports, one was an unused variable and one was the usage of
while(true). None remain.By the way, I hope ignore is the correct catalog entry for this sort of PR, but feel free to change that if necessary.
Screenshots
n/a
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes