timePicker support for Asynchronous Module Definition (AMD) API #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jquery 1.7 adds support for the Asynchronous Module Definition (AMD) API
( https://github.com/amdjs/amdjs-api/wiki/AMD ). It would be great if
timePicker would also now support this. Usually the easiest, most
flexible way to do this is to find the appropriate Universal Module
Definition pattern from https://github.com/umdjs/umd (probably their
simple jqueryPlugin template,
https://github.com/umdjs/umd/blob/master/jqueryPlugin.js ), and apply it to
timePicker.
This is exactly what I did. The resulting change does not interfere with usage by people who do not use a module loader or people who use a non-AMD module loader.