Feature: Add ProfilingData object cache in Profiler#99
Open
glensc wants to merge 2 commits intoperftools:mainfrom
Open
Feature: Add ProfilingData object cache in Profiler#99glensc wants to merge 2 commits intoperftools:mainfrom
glensc wants to merge 2 commits intoperftools:mainfrom
Conversation
This is benefical for long running apps like Laravel Octane.
There was a problem hiding this comment.
Pull request overview
Adds a cached ProfilingData instance inside Profiler to avoid repeatedly constructing ProfilingData on each disable() call—intended to help performance in long-running PHP processes (e.g., Laravel Octane).
Changes:
- Introduce
Profiler::$profilingDataand a privategetProfilingData()lazy-initializer to reuse a singleProfilingDatainstance. - Update
Profiler::disable()to use the cachedProfilingDatainstance. - Add a unit test asserting
getProfilingData()returns the same cached instance across calls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Profiler.php |
Adds a cached ProfilingData property and accessor; disable() now reuses it. |
tests/ProfilerTest.php |
Adds a reflection-based test to verify the ProfilingData instance is cached. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is benefical for long running apps like Laravel Octane.