Skip to content

qa: fix tests using fmt for ubuntu2604#2601

Closed
kurik wants to merge 1 commit into
performancecopilot:mainfrom
kurik:fmt
Closed

qa: fix tests using fmt for ubuntu2604#2601
kurik wants to merge 1 commit into
performancecopilot:mainfrom
kurik:fmt

Conversation

@kurik
Copy link
Copy Markdown
Contributor

@kurik kurik commented May 27, 2026

Ubuntu 26.04 ships uutils fmt, not GNU one. It breaks formating for qa/338 and qa/1473.
This fix restores back the fallback before ad0044a commit.

Ubuntu 26.04 ships uutils fmt, not GNU one. This breaks formating for
qa/338 and qa/1473. This fix restores back the falback before ad0044a
commit.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Two test filter scripts in qa/1473 and qa/338 update their _filter() function to probe fmt -w 64 capability instead of GNU-specific fmt -g 76 -w 76, streamlining the detection logic while maintaining fallback paths for alternative fmt variants.

Changes

fmt Capability Detection Modernization

Layer / File(s) Summary
Update _filter() fmt probe from -g 76 -w 76 to -w 64
qa/1473, qa/338
Both test filter scripts replace GNU fmt -g 76 -w 76 detection with a simpler fmt -w 64 probe, updating the selected command invocation and comments while preserving the fallback behavior for other fmt variants.

🐰 Golden files now skip GNU's -g flag,
The probe grows lean with -w 64 tag,
Two filters harmonize their way,
Simplifying how they format the day,
Archive and test both skip and play!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title refers to 'ubuntu2604' but the PR description and objectives mention 'ubuntu2606' and 'Ubuntu 26.04', indicating a version mismatch that makes the title inaccurate. Update the title to 'qa: fix tests using fmt for ubuntu2606' to match the actual target Ubuntu version mentioned in the PR objectives and description.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is relevant and provides context about the issue: Ubuntu 26.04 ships uutils fmt which breaks qa/338 and qa/1473, and the fix restores previous fallback behavior from before commit ad0044a.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kurik kurik changed the title qa: fix tests using fmt for ubuntu2606 qa: fix tests using fmt for ubuntu2604 May 28, 2026
@kurik kurik requested a review from kmcdonell May 28, 2026 04:05
@kurik
Copy link
Copy Markdown
Contributor Author

kurik commented May 28, 2026

@kmcdonell, could you please review this, as you are the author of commit ad0044a?

Copy link
Copy Markdown
Member

@kmcdonell kmcdonell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurik I think it is simpler than this. My changes from the earlier commit are cut-n-paste-wrong. The qa tests were passing by accident.
The QA tests need a :g/ 76/s// 64/g in qa/338 and qa/1473.
This works for me on Ubuntu 24.04 and 26.04 ... if you gimme 24 hours I'll make sure it works on the *BSD and OpenIndiana platforms, then either you can rework this PR, or close it and leave it to me to clean up my mess with a new PR.
I'll wait for your response.

@kurik
Copy link
Copy Markdown
Contributor Author

kurik commented May 28, 2026

@kmcdonell OK, I am closing this PR and I leave it to you.
Thanks for looking at this.

@kurik kurik closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants