qa: fix tests using fmt for ubuntu2604#2601
Conversation
Ubuntu 26.04 ships uutils fmt, not GNU one. This breaks formating for qa/338 and qa/1473. This fix restores back the falback before ad0044a commit.
📝 WalkthroughWalkthroughTwo test filter scripts in Changesfmt Capability Detection Modernization
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@kmcdonell, could you please review this, as you are the author of commit ad0044a? |
kmcdonell
left a comment
There was a problem hiding this comment.
@kurik I think it is simpler than this. My changes from the earlier commit are cut-n-paste-wrong. The qa tests were passing by accident.
The QA tests need a :g/ 76/s// 64/g in qa/338 and qa/1473.
This works for me on Ubuntu 24.04 and 26.04 ... if you gimme 24 hours I'll make sure it works on the *BSD and OpenIndiana platforms, then either you can rework this PR, or close it and leave it to me to clean up my mess with a new PR.
I'll wait for your response.
|
@kmcdonell OK, I am closing this PR and I leave it to you. |
Ubuntu 26.04 ships uutils fmt, not GNU one. It breaks formating for qa/338 and qa/1473.
This fix restores back the fallback before ad0044a commit.