pmfind / libpcp_web: fix crashes, hang, and fix pending_timer_init#2559
Open
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Open
pmfind / libpcp_web: fix crashes, hang, and fix pending_timer_init#2559kurik wants to merge 1 commit intoperformancecopilot:mainfrom
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
pmfind (source.c): dictDelete before source_release on remove path; remove pmfind contexts dict entry before bulk release; uv_stop after discovery; call pmWebGroupClose before uv_loop_close, uv_close bootstrap timer, and drain uv_run. webgroup.c: parse context id before on_done and deref via dict lookup so on_done/pmWebGroupDestroy cannot leave a stale cp; defer free(webgroups) until uv_close callbacks complete for embedded timer and async. libpcp_web: remove context from pending_timer_init queue before free. Avoid use-after-free when webgroup_async_cb runs after synchronous destroy.
kurik
changed the title
Contributor
Author
|
@natoscott I finished the work on this (failing 1985, 1986, 1998 tests after #2555). Can you please review, once you have some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #2555 resp. #2557, fixing a memory issue introduced in #2555 as well as some orthogonal issues found by
qa/{1985,1986,1998}.What has been done
pmfind (source.c): dictDelete before source_release on remove path; remove pmfind contexts dict entry before bulk release; uv_stop after discovery; call pmWebGroupClose before uv_loop_close, uv_close bootstrap timer, and drain uv_run.
webgroup.c: parse context id before on_done and deref via dict lookup so on_done/pmWebGroupDestroy cannot leave a stale cp; defer free(webgroups) until uv_close callbacks complete for embedded timer and async.
libpcp_web: remove context from pending_timer_init queue before free. Avoid use-after-free when webgroup_async_cb runs after synchronous destroy.
Testing
The main testing has been performed on RHEL-10 and Fedora-43. Due to unavailability of Debian/Ubuntu environment at the moment to me, I left the check on these platforms on the CI pipeline, especially checking results of
qa/{1985,1986,1998}. All seems to be good to me.