QA #1321 fix to address failure on s390x#2492
Open
lmchilton wants to merge 1 commit intoperformancecopilot:mainfrom
Open
QA #1321 fix to address failure on s390x#2492lmchilton wants to merge 1 commit intoperformancecopilot:mainfrom
lmchilton wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
PR performancecopilot#2448 caused QA test failure performancecopilot#1321 on s390x machines
Member
|
This doesn't make sense to me in the context of the test - see the comment at line 64, it seems that loop is supposed to be happening at the same time that pmlogger is running (in parallel). This change means we do the two stages serially, one after the other, and the pmlogger is put in the background for no reason now (we sleep and then kill it? hmm, bit sus). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2448 caused QA test failure #1321 on s390x machines