add local ip test #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If we add 127.0.0.1, then we should check ::1 as well. |
Author
|
@kritik, Yes. So should I wait for merge or create new pull requests? |
Member
|
What I mean is that I don't like this change because it's not domain but url. Do you have this problem in real world? |
Author
|
For example user should provide some callback url (that I will ping after some event). So in this situation no_local option is very helpful. |
Member
|
Yes, but what I'm asking is do you have faced this problem in real world? |
Author
|
Not yet 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no_local is true, http://127.0.0.1 should not be valid.