-
Notifications
You must be signed in to change notification settings - Fork 36
Update Contributing Document - 18 #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18
Are you sure you want to change the base?
Conversation
This PR updates the contributing guide.
|
|
||
| 2. **[Contribute to documentation yourself](#contribute-to-documentation-yourself)**. Click the <img src="_resource/.icons/edit_page.png" style="width: 1em; height: 1em;"> **Edit this page** icon that leads you to the source file of the page on GitHub. There you make changes, create a pull request that we review and add to the doc project. For details how to do it, read on. | ||
| - Open the [Jira issue tracker](https://jira.percona.com/projects/PG/issues) for the project. | ||
| - (Optional but recommended) Search if the issue you want to report is already reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot search issues without logging in. Steps 2 and 3 should be replaced with one another
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I would split login and create actions into separate steps, TBH
| To start contributing: | ||
|
|
||
| ### Edit documentation online via GitHub | ||
| 1. Click the **Edit this file** icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
banner?
| cd postgresql-docs | ||
| ``` | ||
|
|
||
| 3. Change the directory to ``postgresql-docs`` and add your local repository: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intro message says add local repo while the command shows adding upstream repo. Please align the command with the step explanation
| ```sh | ||
| docker run --rm -v $(pwd):/docs perconalab/pmm-doc-md mkdocs build | ||
| git add . | ||
| git commit -m "<my_fixes>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| git commit -m "<my_fixes>" | |
| git commit -m "PG-123-<my_fixes>" |
| docker run --rm -v $(pwd):/docs perconalab/pmm-doc-md mkdocs build | ||
| git add . | ||
| git commit -m "<my_fixes>" | ||
| git push -u origin <my_branch_name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git push -u origin <my_branch_name>. Otherwise upstream repo is unaware of this change
| This creates a single HTML page for the whole doc project. You can find the page at `site/print_page.html`. | ||
|
|
||
| 7. Open the `site/print_page.html` in your browser and save as PDF. Depending on the browser, you may need to select the Export to PDF, Print - Save as PDF or just Save and select PDF as the output format. | ||
| You can also view the site at <http://127.0.0.1:8000>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have PDFs for PG docs. It makes sense to show how to create a PDF
This PR updates the contributing guide.