nightshift/bug: drag-reorder has no effect — filtered() always sorts by useCount

[perandre]

Bug

SnippetStore.filtered(by:) in Sources/SnippetStore.swift always sorts the snippet list by useCount descending before returning it, even when the query is empty. SnippetStore.move(from:to:) correctly reorders snippets in-place and calls save(), but the very next SwiftUI render calls filtered(by: "") again and re-sorts the array by useCount, silently undoing the user's drag.

Result: drag-to-reorder appears to do nothing — the list springs back to useCount order on every frame.

Repro

1. Add at least two snippets and use them different numbers of times so they have different useCount values.
2. Open the panel with an empty search field.
3. Drag a snippet to a new position.
4. Observe: the list immediately re-sorts itself back to useCount order; the manual position is lost.

Reading the code confirms this without running the app: filtered(by: "") always executes let sorted = snippets.sorted { $0.useCount > $1.useCount } and returns sorted, discarding move()'s reorder.

Fix

filtered(by:) now returns snippets (stored order) directly when the query is empty, and only sorts by useCount when a non-empty search query is active so the most-relevant results surface first.

// before
func filtered(by query: String) -> [Snippet] {
    let sorted = snippets.sorted { $0.useCount > $1.useCount }
    guard !query.isEmpty else { return sorted }
    …
}

// after
func filtered(by query: String) -> [Snippet] {
    guard !query.isEmpty else { return snippets }
    return snippets
        .filter { … }
        .sorted { $0.useCount > $1.useCount }
}