Replace native execution. #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
approved these changes
Mar 3, 2025
Member
ebma
left a comment
ebma
left a comment
There was a problem hiding this comment.
So you managed to sync the chain on Foucoco with this change? 🥹 Great find 🙏
ebma
approved these changes
Mar 4, 2025
Member
|
@gianfra-t shall we merge this and create a new release? We can roll out and test it on Foucoco afterward. |
Member
|
Should we close the ticket of this PR? |
Member
|
Not yet, We have to check how it behaves on Foucoco after rolling it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 518.
Context
Since the metadata-hash chain extension cannot be used with the native runtime execution, and it's use seems to be deprecated as well, we replace the use of
NativeElseWasmExecutorand useWasmExecutordirectly.