Skip to content

fix: Card select issue in selectable card #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 2 commits into from
Mar 20, 2026
Merged

fix: Card select issue in selectable card #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d4bdc
fix: Card select issue in selectable card
tammy-a11y Mar 20, 2026
e1e6018
Merge branch 'master' into fix/selectableCard
tumms2021389 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/react-sdk-components/src/components/field/SelectableCard/SelectableCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@ export default function SelectableCard(props) {
const cardDataSource = readOnly || displayMode === 'DISPLAY_ONLY' ? readOnlyList || [] : dataSource?.source;
const imageDescriptionKey = showImageDescription ? imageDescription : undefined;

const handleCardClick = event => {
if (disabled || readOnly) return;
// If the click landed on or inside a label/input, native behavior already handles it.
if (event.target.closest?.('label, input')) return;
// Find the radio/checkbox input inside this card and click it programmatically.
const input = event.currentTarget.querySelector('input[type="radio"], input[type="checkbox"]');
if (input) input.click();
};

let radioItemSelected = false;

return (
Expand Down Expand Up @@ -75,7 +84,12 @@ export default function SelectableCard(props) {

const component = (
<div key={item[recordKey]} style={{ paddingTop: '15px' }}>
<Card className={className} style={{ display: 'flex', flexDirection: 'column', height: '100%' }} data-testid={testId}>
<Card
className={className}
style={{ display: 'flex', flexDirection: 'column', height: '100%', cursor: disabled || readOnly ? 'default' : 'pointer' }}
data-testid={testId}
onClick={handleCardClick}
>
<CardContent
style={{
...((imagePosition === 'inline-start' || imagePosition === 'inline-end') && { display: 'flex', height: '100%' }),
Expand Down Expand Up @@ -118,7 +132,7 @@ export default function SelectableCard(props) {
onBlur={onBlur}
onClick={onClick}
onKeyDown={onKeyDown}
disabled={disabled}
disabled={disabled || readOnly}
{...additionalProps}
/>
}
Expand All @@ -135,7 +149,7 @@ export default function SelectableCard(props) {
onBlur={onBlur}
onClick={onClick}
onKeyDown={onKeyDown}
disabled={disabled}
disabled={disabled || readOnly}
{...additionalProps}
/>
}
Expand Down
Loading