feat: add BnB algorithm for coin selection#40
Open
Cyrix126 wants to merge 2 commits into
Open
Conversation
Collaborator
|
@Cyrix126 Thank you for this. This would be excellent to include in v5.0.0 so rebasing to v5.0.0 would be ideal. Unfortunately I'm not sure when I'll get chance to fully review and then I'm not sure when I can finish v5.0.0 which is blocked by two things. The first thing is Windows support #37. The second thing is that there is memory corruption when using MuSig2 with WASM. I might release v5.0.0 without Windows support (unless I can get help confirming Windows works OK) and I might make MuSig2 unavailable for web. |
Collaborator
|
The unit tests fail on the web target due to the call depth of the search function. Can the algorithm be made non-recursive? |
- fix: wasm target - fix: allow to increase maxCandidate number without overflowing
Author
|
I rewrote the part that was using recursion. That will fix the wasm build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3
Make BnB the default algorithm to select coins. Fall back to the older one if it doesn't find a solution.
Note for v5: the only thing to change would be the locktime parameter from int to Locktime type.