Convert the test suite to PHPUnitPolyFills and update to PHP 8 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite itself is not changed. For now we test only on Ubuntu and macOS because we need sudo.
This comment was marked as off-topic.
This comment was marked as off-topic.
duboism
changed the title
The file is deprecated for recent PHPUnit.
This implies to delete AllTests.php
This comment was marked as off-topic.
This comment was marked as off-topic.
ashnazg
approved these changes
Nov 24, 2024
Contributor
Author
|
Thank you @ashnazg ! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
Thanks :)
Ah, I forgot your request. I still don't have enough power for that but I will talk to @ashnazg about the best course of action. Or maybe even better @Neustradamus, subscribe to the pear-general ML and ask yourself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the test suite to PHPUniPolyFills which allow the test suite to run on many versions of PHPUnit (this library is recommended on PHPUnit home page so I think it's a robust solution). Therefore, we can run on all current versions of PHP.
There is almost no change to the code itself except:
Yoast\PHPUnitPolyfills\TestCases\TestCaseso they must implementset_up/tear_down(instead ofsetUp/tearDown). See the doc here.AllTests.phpbecause I could not port it. AFAIU, it doesn't change the tests.This PR is based on the branch used for PR #16 (so this one must be merged first and I must rebase). It only adds d6dd558 and 74c8855.
Also it replaces #15.