-
Notifications
You must be signed in to change notification settings - Fork 18
Compat php7.4 / php8 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…a/HTML_Template_IT
no more use the php4 constructor method
dont break the php4 constructor api
ref#50469 Replaced preg_replace with /e by preg_replace_callback
#64906 Rename class to fit PSR-0
…sts and add a setGlobalOptions method
|
Hi @duboism, To be honest, I can't remember why I closed this MR... We're using this version in production env with php 7.4 https://github.com/Elma/HTML_Template_IT/tree/1.4.0 |
|
Hi @geelweb, I can understand your motivation but the situation is rather weird now as we have 2 divergent forks releasing identically tagged versions. Note that this repository is published in packagist (https://packagist.org/packages/pear/html_template_it) so it's easier to find. We run the current stable version from this repository (v1.3.1) in production under PHP 7.4 (installed from packagist). IIRC, I think that the current master runs under PHP8 but the test suite needs some work. I hope to be able to work on that soon (the rationale being that we want to move our production env to PHP 8 so we need this code for PHP 8.). As you tackled things like that in your MR, maybe we can collaborate on this. |
|
Just for your information, I opened #15 to do a basic port of the test suite to PHP 8. Feel free to add ideas there. |
No description provided.