Skip to content

Conversation

@geelweb
Copy link

@geelweb geelweb commented Apr 11, 2022

No description provided.

@geelweb geelweb closed this Apr 11, 2022
@duboism
Copy link
Contributor

duboism commented Apr 19, 2024

Hello,

I have never noticed this PR before. In fact, I'm not sure it existed when I tried to port the code to PHP8 (see #11 and #12).

I feel that the PR does a lot of modifications. Why what it closed without merging ?

@geelweb
Copy link
Author

geelweb commented Apr 25, 2024

Hi @duboism,

To be honest, I can't remember why I closed this MR... We're using this version in production env with php 7.4 https://github.com/Elma/HTML_Template_IT/tree/1.4.0

@duboism
Copy link
Contributor

duboism commented Apr 26, 2024

Hi @geelweb,

I can understand your motivation but the situation is rather weird now as we have 2 divergent forks releasing identically tagged versions. Note that this repository is published in packagist (https://packagist.org/packages/pear/html_template_it) so it's easier to find.

We run the current stable version from this repository (v1.3.1) in production under PHP 7.4 (installed from packagist).

IIRC, I think that the current master runs under PHP8 but the test suite needs some work. I hope to be able to work on that soon (the rationale being that we want to move our production env to PHP 8 so we need this code for PHP 8.). As you tackled things like that in your MR, maybe we can collaborate on this.

@duboism
Copy link
Contributor

duboism commented Jul 22, 2024

Just for your information, I opened #15 to do a basic port of the test suite to PHP 8. Feel free to add ideas there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants