Skip to content

Conversation

@tangkong
Copy link
Contributor

@tangkong tangkong commented May 14, 2025

Description

  • attempt to figure out why history file tests are failing

Motivation and Context

This test has been timing out on python3.12 and I want to find out why. Perhaps splitting it out will help de-conflict things
See this failure

Locally splitting the single history file test case into 3 separate tests resulted in each taking around 7s. With a timeout of 30s, it makes sense that this sometimes fails. (prior to this change, that test was taking ~23s)

I re-ran the ci python 3.12 conda tests multiple times, and it's passed each time 🤷

How Has This Been Tested?

Interactively, with little success in reproducing the failures seen on CI

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively (a real hutch config file can be loaded)
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong requested a review from a team as a code owner May 14, 2025 16:44
@tangkong tangkong marked this pull request as draft May 14, 2025 16:44
@tangkong tangkong force-pushed the tst_hist_timeouts branch from 1ee2ea8 to 15fe82e Compare May 14, 2025 18:32
@tangkong
Copy link
Contributor Author

of course there's no problem here. 🙃

@tangkong tangkong marked this pull request as ready for review May 14, 2025 20:43
@tangkong tangkong changed the title WIP/TST: fix hist file test timeouts TST: fix hist file test timeouts May 14, 2025
@tangkong
Copy link
Contributor Author

I'll put this up for review and see if it helps. I didn't really solve the underlying problem, but best I could see nothing actually hangs here forever. (locally or on CI)

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forward progress!

@tangkong tangkong merged commit dede000 into pcdshub:master May 14, 2025
11 checks passed
@tangkong tangkong deleted the tst_hist_timeouts branch May 14, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants