-
Notifications
You must be signed in to change notification settings - Fork 18
fix path check #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix path check #400
Conversation
tangkong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, simple sensible change. Just a small change to get the docs build working, but otherwise I think this is good to go.
Thanks for catching this!
docs/source/upcoming_release_notes/400-BUGFIX:_epicsarch-qs_softlink_creation.rst
Show resolved
Hide resolved
tangkong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3.12 test failure is unrelated to this change, and is something we need to look at generally. This looks good to me now, thanks!
Ack, one more small change
|
|
||
| Contributors | ||
| ------------ | ||
| - espov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - espov | |
| - vesops |
These are github usernames, as unclear as it is
Description
Fix bug in the path check for the epicsArch softlink creation
Motivation and Context
Softlink creation was buggy because of the faulty check
How Has This Been Tested?
This worked as expected:
Where Has This Been Documented?
N/A
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page