-
Notifications
You must be signed in to change notification settings - Fork 18
PERF: delay preset loading for hutch-python #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
90915dc to
8c22e1a
Compare
|
I guess there are no real tests to do here, since this is a pcdsdevices feature. |
|
Does this implicitly change our minimum supported pcdsdevices version? Is this something we would address in the conda forge feedstock? |
|
Ah you're right. That slipped my mind. This will technically rely on a pcdsdevices version that doesn't exist yet. I'm reluctant to tag pcdsdevices right now because we might accumulate more changes, but once I change the pins the tests will fail. I'll move this back to WIP until we're ready to more forward. More incentive for me to look at pyca / typhos I guess |
|
I found this again in my PR reviews backlog. Maybe we should tag |
|
Ah yes. This also reminds me of the whole tagging/new-conda-effort we had going a month ago |
8c22e1a to
8bfdf0f
Compare
|
This will fail until we've tagged/deployed pcdsdevices, I've updated the pin here slightly prematurely |
3e499d9 to
17d87f7
Compare
|
Apparently in py3.12 flake8 started linting strings, a problem that was fixed with 6.1.0. I suspect that shifting to ubuntu latest shifted the default python version to 3.12, exposing us to this error. I verified that flake8 v6.0.0 and py3.12 reproduces this Updating the flake8 version in the pre-commit config fixes this |
|
This is good to go now, as long as we're sure that we're ok with ipython being unpinned |
ZLLentz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this
Description
Motivation and Context
We want to defer preset loading for performance reasons.
This will fail tests until the corresponding pcdsdevices PR is merged.
How Has This Been Tested?
I was using this to test presets while developing pcdshub/pcdsdevices#1317
Where Has This Been Documented?
This PR
Left: Before, Right: After

In getting that screenshot I ran into a variety of load times, preset deferral was always better but by varying margins.
Ran on a clone of XCS's hutch-python profile, copied into my dev area
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page