Skip to content

fix: URL-encode in Vault secret paths#39

Open
monchaio wants to merge 3 commits into
pbchekin:mainfrom
monchaio:main
Open

fix: URL-encode in Vault secret paths#39
monchaio wants to merge 3 commits into
pbchekin:mainfrom
monchaio:main

Conversation

@monchaio
Copy link
Copy Markdown

@monchaio monchaio commented May 2, 2026

Summary

  • Fix bug where Vault secret paths containing backslashes were not properly handled
  • Backslashes are now URL-encoded to prevent path parsing errors

Problem

  • Secret paths with backslashes (e.g., domain\user style paths) were failing to sync because the backslash was interpreted as a path separator instead of part of the secret name.

Test Plan

  • Added unit tests for backslash encoding
  • Verified syncing secrets with \ characters in the path

Copy link
Copy Markdown
Owner

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for identifying the issue and for the fix. To go forward, I think there should be an integration test added to the code. The issue itself needs to be fixed in the underlying low level library vault-rs, which is forked and vendored in this repository. Do you think you can make the required changes?

Comment thread src/sync.rs Outdated
Comment thread vault-rs/src/client/mod.rs Outdated
@monchaio monchaio changed the title fix: URL-encode backslashes in Vault secret paths fix: URL-encode in Vault secret paths May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants