Skip to content

Address issue https://github.com/pb33f/wiretap/issues/143 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daveshanley merged 1 commit into from
Mar 15, 2026
+4 −2
Merged

Address issue https://github.com/pb33f/wiretap/issues/143 #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion renderer/mock_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ func (mg *MockGenerator) renderMockJSON(v any) []byte {
data, _ = json.Marshal(v)
}
default:
data = []byte(fmt.Sprint(v))
// use json.Marshal for scalar types to produce valid JSON
// (e.g. strings get properly quoted: "bob" not bob)
data, _ = json.Marshal(v)
}
return data
}
Expand Down
2 changes: 1 addition & 1 deletion renderer/mock_generator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func TestMockGenerator_GenerateJSONMock_NoExamples_JSON(t *testing.T) {
mg := NewMockGenerator(JSON)
mock, err := mg.GenerateMock(fake, "")
assert.NoError(t, err)
assert.Equal(t, "magic-herbs", string(mock))
assert.Equal(t, `"magic-herbs"`, string(mock))
}

func TestMockGenerator_GenerateJSONMock_NoExamples_YAML(t *testing.T) {
Expand Down
Loading