feat(richtext-lexical): add separate fields for icons in lexical blocks#15632
Open
VeiaG wants to merge 2 commits intopayloadcms:mainfrom
Open
feat(richtext-lexical): add separate fields for icons in lexical blocks#15632VeiaG wants to merge 2 commits intopayloadcms:mainfrom
VeiaG wants to merge 2 commits intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new
iconImageURLandiconImageAltTextfields toBlockConfig, allowing developers to specify separate images for:Why
Currently,
imageURLserves dual purposes:Citing documentation:
This creates problem , where developer needs to choose either good looking icons (but worse UX on block drawers) or good looking thumnails, but scaled down images as icons.
Solution
Add dedicated
iconImageURLfield with fallback chain:Now you can set different URL for block icons in lexical blocks:

Backwards Compatibility
Fully backwards compatible - no breaking changes , new fields are conditional with fallback to previous behaviour