Skip to content

Conversation

@benalleng
Copy link
Collaborator

After #745 I realized we can go further and completely remove the FinalizeResponseError in favor of using FinalizedError which already has access to DirectoryResponse errors.

After payjoin#745 I realized we can go further and completely remove the
FinalizeResponseError in favor of using FinalizedError which already has
access to DirectoryResponse errors.
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 911154e

@spacebear21 spacebear21 merged commit 91f3e15 into payjoin:master Jun 12, 2025
7 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 15619977334

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.035%

Totals Coverage Status
Change from base Build 15619667911: 0.1%
Covered Lines: 7128
Relevant Lines: 8285

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants