Conversation
Pull Request Test Coverage Report for Build 23145192620Details
💛 - Coveralls |
arminsabouri
left a comment
There was a problem hiding this comment.
CAck cf8b0b7
big pickle? Cool.
Should we / do we already ensure that there is > 2 ohttp relays ?
|
This PR also includes the commit from #1390, is it meant to supersede that PR? I left a comment there that I think we should address holistically (i.e. is ohttp_keys "cache" config field relevant at all since we refetch every time anyways?) |
|
I should add blocked as this simply builds on top of #1390 This PR would have simply needed to also add the commit from #1390 as the ohttp_keys have been "cached" by that point so relay selection is skipped and resume would just choose |
This commit ensures that each resumed payjoin-cli session is using a separate instance of the RelayManager to then check the ohttp connection independently. This fixes a bug where resuming would converge all existing sessions to one ohttp relay.
cf8b0b7 to
5062488
Compare
bc1cindy
left a comment
There was a problem hiding this comment.
tACK 5062488
minimal fix, each resumed session gets a fresh RelayManager, isolating relay state between sessions
but I think removing state from RelayManager and moving randomization into the struct as a method could simplify the design further, as commented in #1385 (comment)
Closes #1391
This commit ensures that each resumed payjoin-cli session is using a
separate instance of the RelayManager to then check the ohttp connection
independently. This fixes a bug where resuming would converge all
existing sessions to one ohttp relay.
Also, the incompatible_msrv allow seems not needed anymore?
Big pickle wrote most of this code. The free open weight models aren't too shabby now either. Though it did want to recreate the entire config instead of just making the app mutable. I thought this seemed a bit easier to parse as its clear everything else is the same.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.