Add C# language bindings for payjoin-ffi#1318
Conversation
Pull Request Test Coverage Report for Build 22036417669Details
💛 - Coveralls |
b4799da to
ae74db7
Compare
|
BOOYEAH I like the direction this is going. |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> |
There was a problem hiding this comment.
Is net8.0 the most common target? I'm very curious what the actual needs of a BTCpayServer plugin or Strike are, because I've dealt with incompatibility issue here, albeit years ago.
There was a problem hiding this comment.
it can: https://blog.btcpayserver.org/btcpay-server-1-12-0/#upgrade-to-net-8. Strike is likely ahead because they don't need to support a bunch of open source stuff.
There was a problem hiding this comment.
I see, any idea which specific runtime they're on?
I did a quick check beforehand to target the most common runtime right now...
Gonna look loser into the Strike repos specifically
There was a problem hiding this comment.
strike very likely on net8.0. probably private repos. i'll ask their team
|
I've been working on an experimental C# bindings prototype in my fork (ValeraFinebits#1) while building a BTCPayServer Payjoin plugin, mainly to explore integration possibilities. This PR aligns closely with what I implemented there, and in my local testing everything works as expected. I'll migrate my plugin to these upstream bindings and share any issues or improvement ideas as I go. |
ae74db7 to
4e75d20
Compare
|
Hi @ValeraFinebits I saw your PR open and close. Thanks bigly for writing us updates here. Very eager to see what that plugin can do and challenges hooking it up to BTCPay via the plugin framework. |
51b49eb to
ef26b10
Compare
ef26b10 to
769f0a9
Compare
This work in progress adds C# bindings and implements tests following the pattern in the other languages