Skip to content

Add C# language bindings for payjoin-ffi#1318

Open
chavic wants to merge 3 commits intopayjoin:masterfrom
chavic:chavic/c-sharp-bindings
Open

Add C# language bindings for payjoin-ffi#1318
chavic wants to merge 3 commits intopayjoin:masterfrom
chavic:chavic/c-sharp-bindings

Conversation

@chavic
Copy link
Collaborator

@chavic chavic commented Feb 9, 2026

This work in progress adds C# bindings and implements tests following the pattern in the other languages

@coveralls
Copy link
Collaborator

coveralls commented Feb 9, 2026

Pull Request Test Coverage Report for Build 22036417669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.18%

Totals Coverage Status
Change from base Build 22022393890: 0.0%
Covered Lines: 10217
Relevant Lines: 12283

💛 - Coveralls

@chavic chavic force-pushed the chavic/c-sharp-bindings branch 2 times, most recently from b4799da to ae74db7 Compare February 9, 2026 12:14
@DanGould
Copy link
Contributor

DanGould commented Feb 9, 2026

BOOYEAH

I like the direction this is going.

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is net8.0 the most common target? I'm very curious what the actual needs of a BTCpayServer plugin or Strike are, because I've dealt with incompatibility issue here, albeit years ago.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can: https://blog.btcpayserver.org/btcpay-server-1-12-0/#upgrade-to-net-8. Strike is likely ahead because they don't need to support a bunch of open source stuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, any idea which specific runtime they're on?

I did a quick check beforehand to target the most common runtime right now...

Gonna look loser into the Strike repos specifically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strike very likely on net8.0. probably private repos. i'll ask their team

@ValeraFinebits
Copy link

I've been working on an experimental C# bindings prototype in my fork (ValeraFinebits#1) while building a BTCPayServer Payjoin plugin, mainly to explore integration possibilities.

This PR aligns closely with what I implemented there, and in my local testing everything works as expected. I'll migrate my plugin to these upstream bindings and share any issues or improvement ideas as I go.

@chavic chavic force-pushed the chavic/c-sharp-bindings branch from ae74db7 to 4e75d20 Compare February 12, 2026 15:34
@DanGould
Copy link
Contributor

Hi @ValeraFinebits I saw your PR open and close. Thanks bigly for writing us updates here. Very eager to see what that plugin can do and challenges hooking it up to BTCPay via the plugin framework.

@chavic chavic force-pushed the chavic/c-sharp-bindings branch from 51b49eb to ef26b10 Compare February 15, 2026 13:15
@chavic chavic force-pushed the chavic/c-sharp-bindings branch from ef26b10 to 769f0a9 Compare February 15, 2026 13:22
@chavic chavic requested a review from spacebear21 February 15, 2026 13:41
@chavic chavic self-assigned this Feb 15, 2026
@chavic chavic requested a review from DanGould February 15, 2026 13:41
@chavic chavic marked this pull request as ready for review February 15, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants