Clean up FFI package names #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the "_dart". Just "payjoin". It's cleaner.
Collaborator
Pull Request Test Coverage Report for Build 19684279756Details
💛 - Coveralls |
spacebear21
force-pushed
the
ffi-rename-libraries
branch
2 times, most recently
from
ff9b3fe to
40151d3
Compare
This rev contains several fixes, one of which is necessary to properly parse the ffi library namespace in the next commit.
Downstream bindings consumers should be able to just "import payjoin", it's cleaner than "import payjoin_ffi". Furthermore, the "bitcoin" namespace is not suffixed with `_ffi` so it's also more consistent internally.
spacebear21
force-pushed
the
ffi-rename-libraries
branch
from
40151d3 to
f78edcf
Compare
Collaborator
Author
Correct, AFAIK the only person tinkering on this currently is Michael from Bull Bitcoin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the "_dart". Just "payjoin". It's cleaner.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.