Skip to content

Crane based nix derivations#11

Merged
nothingmuch merged 5 commits into
mainfrom
crane
May 22, 2026
Merged

Crane based nix derivations#11
nothingmuch merged 5 commits into
mainfrom
crane

Conversation

@nothingmuch
Copy link
Copy Markdown
Collaborator

@nothingmuch nothingmuch commented May 21, 2026

Adds rust-overlay based toolchains and use them to define crane based derivations, starting with a package for the crate. This becomes a check that the crate builds with the toolchains.

Depends on #8

@nothingmuch nothingmuch marked this pull request as draft May 21, 2026 20:26
Rust toolchain definitions via rust-overlay. Exports pkgs (with
overlay) and rustToolchains attrset for downstream crane wrapping.
Renames raw toolchains to rustToolchains, wraps with mkCraneLib
via mapAttrs to produce crane-wrapped toolchains attrset for
downstream consumers (package, checks, devshell).
@nothingmuch nothingmuch marked this pull request as ready for review May 21, 2026 21:07
Copy link
Copy Markdown

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK 3370381

With the added toolchains this seems like as good a time as any to add an msrv. Fine to be a follow-up but I don't want to forget. Assuming this repo wants to have a fixed msrv

@nothingmuch
Copy link
Copy Markdown
Collaborator Author

msrv was initially included but i realized i don't really know what it should be, so pending all of the library and cli implementation maturing, then we'll find the lowest reasonable number before a release.

@nothingmuch nothingmuch merged commit 33172fc into main May 22, 2026
1 check passed
@nothingmuch nothingmuch deleted the crane branch May 22, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants