DEV: Improve header dropdown toggle on mobile view #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkshine
force-pushed
the
toggle-header-dropdown
branch
from
96c51c1 to
eadd537
Compare
Arkshine
force-pushed
the
toggle-header-dropdown
branch
from
1db27dc to
152ae40
Compare
Arkshine
force-pushed
the
toggle-header-dropdown
branch
from
0331e09 to
ac025ad
Compare
Contributor
Author
|
I'm not sure why the QUnit test times out after 10 minutes in the CI. I have no issue with local. Did I miss something? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta: https://meta.discourse.org/t/dropdown-header/226170/69?u=arkshine
On mobile view, the header dropdown toggle was never implemented, even before #11.
Also, since a header can have a link, both behaviors overlap.
To avoid introducing a behavior change, this PR does the following on mobile view:
This way, the user will not be misled into thinking that the header dropdown can be toggled when it's supposed to redirect to a URL.
Additionally, it would be beneficial to encourage admins not to define a URL for a header with a dropdown, as it's not immediately evident to the user that they can click on it.
Before:
After:
