Fixing MF7/MT2 key name: LHTR → LTHR#37
Merged
paulromano merged 1 commit intopaulromano:mainfrom Mar 4, 2026
Merged
Conversation
The parsed dictionary key for the thermal elastic scattering law flag in MF7/MT2 is currently stored as LHTR in the endf-python package. The correct ENDF-6 variable name is LTHR (Law for THermal elastic Reaction), as defined in the ENDF-6 Formats Manual (ENDF-102, Section 7.2) and used consistently in NJOY2016, PREPRO, and other processing codes. This typo causes downstream code that looks up sec['LTHR'] to silently get a default of 0 (of course depending on how the code is setup), making it appear that no elastic data is present even when the file correctly contains LTHR data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsed dictionary key for the thermal elastic scattering law flag in MF7/MT2 is currently stored as LHTR in the endf-python package. The correct ENDF-6 variable name is LTHR (Law for THermal elastic Reaction), as defined in the ENDF-6 Formats Manual (ENDF-102, Section 7.2) and used consistently in NJOY2016, PREPRO, and other processing codes.
This typo causes downstream code that looks up ['LTHR'] to silently get a default of 0 (of course depending on how the code is setup), making it appear that no elastic data is present even when the file correctly contains LTHR data.