Skip to content

fix: issue when comparing coils #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulorb merged 1 commit into from
Mar 9, 2026
Merged

fix: issue when comparing coils #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/kotlin/PlcSimulation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
init {
var simulationConfiguration = configurationParser.getConfiguredDevice().simulation
var configuration = configurationParser.getConfiguredDevice().configuration
coroutineScope.async {

Check warning on line 31 in src/main/kotlin/PlcSimulation.kt

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

This function returns "Deferred", but its result is never used. 


See more on https://sonarcloud.io/project/issues?id=paulorb_modbus-simulator-cli&issues=AZzTALmMZHWxYYhb78ls&open=AZzTALmMZHWxYYhb78ls&pullRequest=25
try {
while (this.isActive) {
val startTime = System.currentTimeMillis()
Expand Down Expand Up @@ -494,7 +494,7 @@
throw CancellationException("Error - IfEqual")
}
//compare
if( currentValue.first() != value.toBoolean()){
if( currentValue.first() != value.toBooleanFromBinary()){
//abort and continue
//since the value does not match the condition
return
Expand Down
Loading