Skip to content

Conversation

@adamjohnson
Copy link
Collaborator

@adamjohnson adamjohnson commented Jul 11, 2025

What I did

  1. adds PfeDemoPage.js to package.json exports
  2. This file is used in RHDS E2E testing and needs to be exported.
  3. See test(cta): add regression tests for missing arrow icon RedHat-UX/red-hat-design-system#2473 for more info.

Testing Instructions

  1. View packapge.json file from pfe-tools, verify things look okay.
  2. Verify if any other files in that directory need to be added to the exports list.

Notes to Reviewers

Looks like there are some pfe-search-input commits in here. Feel free to change the base branch if applicable.

@adamjohnson adamjohnson self-assigned this Jul 11, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

⚠️ No Changeset found

Latest commit: d6947a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tools): add `PfeDemoPage.js` to `package.json` exports"
}

@netlify
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit d6947a3
🔍 Latest deploy log https://app.netlify.com/projects/patternfly-elements/deploys/687785814334930008b7fa5a
😎 Deploy Preview https://deploy-preview-2913--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jul 11, 2025
@github-actions

This comment has been minimized.

@bennypowers bennypowers force-pushed the fix/tools/tests-pfe-demo-page-exports branch from 7eee5b5 to d6947a3 Compare July 16, 2025 10:57
@bennypowers bennypowers enabled auto-merge (squash) July 16, 2025 10:57
@bennypowers bennypowers disabled auto-merge July 16, 2025 10:57
@bennypowers bennypowers enabled auto-merge (squash) July 16, 2025 10:57
@bennypowers bennypowers merged commit 9cba233 into main Jul 16, 2025
31 checks passed
@bennypowers bennypowers deleted the fix/tools/tests-pfe-demo-page-exports branch July 16, 2025 10:59
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

SSR Test Run for 9c3a14f: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants