Skip to content

Conversation

@bennypowers
Copy link
Member

the pull_request_target event runs in the base context, e.g. the main branch, not in the pr branch

therefore this fails for new elements, because the commitlint script can't find the element name for an element which doesn't exist yet on main

What I did

  1. remove pull request target event from prlint workflow

the pull_request_target event runs in the base context, e.g. the main branch, not in the pr branch

therefore this fails for new elements, because the commitlint script can't find the element name for an element which doesn't exist yet on main
@bennypowers bennypowers requested a review from ArathyKumar June 5, 2025 09:38
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: f3bb3a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore: update commitlint.yml"
}

@netlify
Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 3960d18
😎 Deploy Preview https://deploy-preview-2910--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Jun 5, 2025
Copy link
Collaborator

@ArathyKumar ArathyKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

SSR Test Run for 3960d18: Report

@ArathyKumar ArathyKumar merged commit 6f49a79 into main Jun 5, 2025
16 of 17 checks passed
@ArathyKumar ArathyKumar deleted the chore/prlint/dont-run-on-main branch June 5, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants