Skip to content

Conversation

@bennypowers
Copy link
Member

What I did

  1. make tooltip content inert when hidden. Fixes pf-tooltip component leaks internal slot content on copy-paste #2902

Testing Instructions

  1. view repro instructions in linked issue

Notes to Reviewers

  1. Pay attention to a11y / SR use

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 63375c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tooltip): make content inert when hidden"
}

1 similar comment
@github-actions
Copy link
Contributor

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tooltip): make content inert when hidden"
}

@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e1a9f63
😎 Deploy Preview https://deploy-preview-2908--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers enabled auto-merge (squash) May 12, 2025 14:47
@bennypowers bennypowers requested a review from adamjohnson May 12, 2025 14:47
@github-actions github-actions bot added the AT passed Automated testing has passed label May 12, 2025
@github-actions
Copy link
Contributor

SSR Test Run for 19509b9: Report

@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 63375c1
🔍 Latest deploy log https://app.netlify.com/projects/patternfly-elements/deploys/68851a0170061b000846f660
😎 Deploy Preview https://deploy-preview-2908--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@adamjohnson
Copy link
Collaborator

I have requested more detailed instructions from Tejas about what words/characters to specifically hightlight and copy/paste.

In my initial review, it appears this PR doesn't solve Tejas's issue. Results appear to be identical in this PR's DP and on pfe.org.

Interestingly, you get different clipboard results when copy/pasting into a text document versus Google Docs. Not sure if this is a PFE or Google Docs thing. 🤷‍♂️

Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With updated guidance from Tejas, I can confirm these changes do not fix his copy/paste issue.

@zeroedin
Copy link
Contributor

Likely we need a user-select: none; on the tooltip text.

@github-actions
Copy link
Contributor

SSR Test Run for e1a9f63: Report

@github-actions
Copy link
Contributor

SSR Test Run for a7b2a5b: Report

Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave Ghost Text Missing

@bennypowers bennypowers merged commit d36adee into main Jul 29, 2025
15 checks passed
@bennypowers bennypowers deleted the fix/tooltip/inert-content branch July 29, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pf-tooltip component leaks internal slot content on copy-paste

4 participants