-
Notifications
You must be signed in to change notification settings - Fork 106
fix(tooltip): make content inert when hidden #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 63375c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tooltip): make content inert when hidden"
} |
1 similar comment
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tooltip): make content inert when hidden"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
|
I have requested more detailed instructions from Tejas about what words/characters to specifically hightlight and copy/paste. In my initial review, it appears this PR doesn't solve Tejas's issue. Results appear to be identical in this PR's DP and on pfe.org. Interestingly, you get different clipboard results when copy/pasting into a text document versus Google Docs. Not sure if this is a PFE or Google Docs thing. 🤷♂️ |
adamjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With updated guidance from Tejas, I can confirm these changes do not fix his copy/paste issue.
|
Likely we need a |
adamjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave Ghost Text Missing
What I did
Testing Instructions
Notes to Reviewers